fix(autocapture): prevent potential memory exhaustion when generating…

… combinations (#863) * fix(autocapture): prevent potential memory exhaustion when generating combinations for CSS Selector
amplitude · Sep 5, 2024 · 6fd6495 · 6fd6495
1 parent 30a2da3
commit 6fd6495
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/plugin-autocapture-browser/src/helpers.ts b/packages/plugin-autocapture-browser/src/helpers.ts
@@ -131,6 +131,7 @@ export const getSelector = (element: Element, logger?: Logger): string => {
   try {
     selector = finder(element, {
       className: (name: string) => name !== constants.AMPLITUDE_VISUAL_TAGGING_HIGHLIGHT_CLASS,
+      maxNumberOfTries: 1000,
     });
     return selector;
   } catch (error) {

diff --git a/packages/plugin-autocapture-browser/src/libs/finder.ts b/packages/plugin-autocapture-browser/src/libs/finder.ts
@@ -132,10 +132,13 @@ function bottomUpSearch(
 }
 
 function findUniquePath(stack: Knot[][], fallback?: () => Path | null): Path | null {
-  const paths = sort(combinations(stack));
-  if (paths.length > config.threshold) {
+  // Check first the total number of combinations first since generating the combinations can cause memory exhaustion
+  const numCombinations = stack.reduce((acc, i) => acc * i.length, 1);
+  if (numCombinations > config.threshold) {
     return fallback ? fallback() : null;
   }
+
+  const paths = sort(combinations(stack));
   for (const candidate of paths) {
     if (unique(candidate)) {
       return candidate;