fix(analytics-browser): should track file download when with url params

amplitude · Oct 18, 2024 · e11756e · e11756e
1 parent 29aec29
commit e11756e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/analytics-browser/src/plugins/file-download-tracking.ts b/packages/analytics-browser/src/plugins/file-download-tracking.ts
@@ -78,7 +78,7 @@ export const fileDownloadTracking = (): EnrichmentPlugin => {
       };
 
       const ext =
-        /\.(pdf|xlsx?|docx?|txt|rtf|csv|exe|key|pp(s|t|tx)|7z|pkg|rar|gz|zip|avi|mov|mp4|mpe?g|wmv|midi?|mp3|wav|wma)$/;
+        /\.(pdf|xlsx?|docx?|txt|rtf|csv|exe|key|pp(s|t|tx)|7z|pkg|rar|gz|zip|avi|mov|mp4|mpe?g|wmv|midi?|mp3|wav|wma)(\?.+)?$/;
 
       // Adds listener to existing anchor tags
       const links = Array.from(document.getElementsByTagName('a'));

diff --git a/packages/analytics-browser/test/plugins/file-download-tracking.test.ts b/packages/analytics-browser/test/plugins/file-download-tracking.test.ts
@@ -36,9 +36,12 @@ describe('fileDownloadTracking', () => {
     expect(amplitude.track).toHaveBeenCalledTimes(0);
   });
 
-  test('should track file_download event', async () => {
+  test.each([
+    'https://analytics.amplitude.com/files/my-file.pdf',
+    'https://analytics.amplitude.com/files/my-file.pdf?foo=bar',
+  ])('should track file_download event', async (value) => {
     // setup
-    document.getElementById('my-link-id')?.setAttribute('href', 'https://analytics.amplitude.com/files/my-file.pdf');
+    document.getElementById('my-link-id')?.setAttribute('href', value);
     const config = createConfigurationMock();
     const plugin = fileDownloadTracking();
     await plugin.setup?.(config, amplitude);
@@ -54,7 +57,7 @@ describe('fileDownloadTracking', () => {
       [FILE_NAME]: '/files/my-file.pdf',
       [LINK_ID]: 'my-link-id',
       [LINK_TEXT]: 'my-link-text',
-      [LINK_URL]: 'https://analytics.amplitude.com/files/my-file.pdf',
+      [LINK_URL]: value,
     });
 
     // stop observer and listeners