-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: react-native with web support #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!!! mostly asking questions here, and suggesting other code may be omitted
...s-react-native/android/src/main/java/com/amplitude/reactnative/AmplitudeReactNativeModule.kt
Outdated
Show resolved
Hide resolved
bgiori
commented
Jul 14, 2022
...ytics-react-native/android/src/main/java/com/amplitude/reactnative/AndroidContextProvider.kt
Show resolved
Hide resolved
...ages/analytics-react-native/android/src/main/java/com/amplitude/reactnative/AndroidLogger.kt
Show resolved
Hide resolved
packages/analytics-react-native/android/src/main/java/com/amplitude/reactnative/Utils.kt
Show resolved
Hide resolved
kevinpagtakhan
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exciting!
kevinpagtakhan
approved these changes
Jul 15, 2022
curiousYi
pushed a commit
to curiousYi/Amplitude-TypeScript
that referenced
this pull request
Jan 26, 2023
* Addng Infobip docs * Fixing svg viewbox * language tweaks * fixing broken codesamples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
analytics-react-native
package, published as@amplitude/analytics-react-native
Diff between
packages/analytics-browser/src
andpackages/analytics-react-native/src
Output:
Diff between
packages/analytics-browser/src/browser-client.ts
andpackages/analytics-react-native/src/react-native-client.ts
Output:
Suggested Follow-up Modularization
Since so much code is shared, we should really re-modularize browser and react-native packages into an
analytics-client-common
package to avoid maintaining two extremely similar source sets.Also, android native code is copied and shared from
Ampliutude-Kotlin
. Need to to merge and publish amplitude/Amplitude-Kotlin#39 then pull in the dependency.Checklist