Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uuid): update uuid.ts based on JS implementation #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

visiodeibc
Copy link

Summary

Hi, this is Jake from the Technical Support team.

There was an issue of user properties being mapped incorrectly due to colliding UUIDs set by the Amplitude TS SDK[due to math.random function].

There was a fix in JS SDK but not carried over to TS SDK

The issue has been stale, so I am making PR for the issue!

Checklist

  • [v] Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@yuhao900914 yuhao900914 requested a review from a team August 15, 2024 23:05
@Mercy811
Copy link
Contributor

Hi @visiodeibc, TS’s analytics-core package is shared by both browser (analytics-browser package) and node (analytics-node package) environments in which crypto should be imported differently. It's predefined in browser environment but it requires to be imported in node environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants