Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics-browser): should track file download when with url params #898

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(analytics-browser): should track file download when with url params #898

merged 1 commit into from
Oct 21, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Oct 18, 2024 •
edited by jira bot
Loading

Summary

Jira: AMP-111576

File download should also track when url contains url parameters.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@Mercy811 Mercy811 merged commit 03c9604 into main Oct 21, 2024
4 checks passed
@Mercy811 Mercy811 deleted the AMP-111576-should-track-file-download-with-url-params branch October 21, 2024 16:48
@kevinpagtakhan
Copy link
Collaborator

amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@izaaz izaaz izaaz approved these changes

@kevinpagtakhan kevinpagtakhan Awaiting requested review from kevinpagtakhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mercy811 @kevinpagtakhan @izaaz @yuhao900914