Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize device info before generating the device ID #491

Merged
merged 4 commits into from
Apr 5, 2024
Merged

fix: initialize device info before generating the device ID #491

merged 4 commits into from
Apr 5, 2024
+20 −9

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Apr 4, 2024

Summary

Quick fix for the last change: I need to initialize the AMPDeviceInfo for the device ID to be generated correctly. Test was written poorly, actually returns nil instead of the empty string.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@bgiori bgiori requested a review from crleona April 4, 2024 23:49
@bgiori bgiori marked this pull request as ready for review April 4, 2024 23:52
crleona
crleona approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@crleona crleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgiori bgiori merged commit 7960a7e into main Apr 5, 2024
3 checks passed
@bgiori bgiori deleted the fix-get-device-id branch April 5, 2024 00:10
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@amplitude-sdk-bot
chore(release): 8.19.1 [skip ci]
b25fab0 
## [8.19.1](v8.19.0...v8.19.1) (2024-04-05)

### Bug Fixes

* assign deviceId correctly on new device ([#492](#492)) ([a200db0](a200db0))
* initialize device info before generating the device ID ([#491](#491)) ([7960a7e](7960a7e))
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 8.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crleona crleona crleona approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgiori @crleona @justin-fiedler