Fix: Don't report two app open events at initial launch #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crleona
force-pushed
the
AMP-98172-fix-double-app-open
branch
from
527c963
to
88a21c4
Compare
yuhao900914
approved these changes
Apr 20, 2024
|
🎉 This PR is included in version 8.19.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UIApplicationWillEnterForegroundNotification fires both at initial launch and when returning from the background. Because we were using a different notification (UIApplicationDidFinishLaunchingNotification) to detect if the app open was from the background, we effectively were firing the event twice. Instead, rely on UIApplicationState to determine if we were opened from the background.
Checklist