fix: resolve catastrophic backtracing issue with semver regex #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +34,7 @@ internal data class SemanticVersion( | |||
| if (version == null) { | |||
| return null | |||
| } | |||
| val matchGroup = regex.matchEntire(version)?.groupValues ?: return null | |||
| val matchGroup = pattern.matchEntire(version)?.groupValues ?: return null | |||
| val major = matchGroup[1].toIntOrNull() ?: return null | |||
| val minor = matchGroup[2].toIntOrNull() ?: return null | |||
| val patch = matchGroup[4].toIntOrNull() ?: 0 | |||
There was a problem hiding this comment.
Are the matchGroup indices still correct? Does it start from 0? What do index 0 and 3 represent?
There was a problem hiding this comment.
Yep!
0 is the full match
3 is everything after the 2nd .
sandeep-madugula
approved these changes
Jul 24, 2024
zhukaihan
approved these changes
Jul 24, 2024
tyiuhc
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.