feat: Golang Local Evaluation V2 · amplitude/experiment-go-server@f18ec9a

Triggered via pull request December 21, 2023 05:30

bgiori

synchronize #18

local-eval-v2

Status Failure

Total duration 28s

Artifacts –

build.yml

on: pull_request

10 errors

Lint: pkg/experiment/local/assignment_service.go#L10

const `flagTypeHoldoutGroup` is unused (unused)

Lint: pkg/experiment/local/client.go#L188

func `(*Client).doRules` is unused (unused)

Lint: internal/evaluation/selectable.go#L43

S1034: assigning the result of this type assertion to a variable (switch s := s.(type)) could eliminate type assertions in switch cases (gosimple)

Lint: internal/evaluation/selectable.go#L45

S1034(related information): could eliminate this type assertion (gosimple)

Lint: internal/evaluation/selectable.go#L47

S1034(related information): could eliminate this type assertion (gosimple)

Lint: internal/evaluation/selectable.go#L49

S1034(related information): could eliminate this type assertion (gosimple)

Lint: internal/evaluation/engine.go#L284

S1005: unnecessary assignment to the blank identifier (gosimple)

Lint: internal/evaluation/engine_test.go#L29

ineffectual assignment to err (ineffassign)

Lint: cmd/xpmt/main.go#L140

SA1019: client.Flags is deprecated: This function returns an old data model that is no longer used. (staticcheck)

issues found