fix: assignment track defaults and details (#19)

amplitude · Dec 21, 2023 · b46239f · b46239f
1 parent f0d4504
commit b46239f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/experiment/local/assignment_service.go b/pkg/experiment/local/assignment_service.go
@@ -31,7 +31,7 @@ func toEvent(assignment *assignment) amplitude.Event {
 
 	// Loop to set event_properties
 	for resultsKey, result := range assignment.results {
-		version, _ := result.Metadata["version"].(int)
+		version, _ := result.Metadata["flagVersion"].(float64)
 		segmentName, _ := result.Metadata["segmentName"].(string)
 		event.EventProperties[fmt.Sprintf("%s.variant", resultsKey)] = result.Key
 		if version != 0 && len(segmentName) > 0 {

diff --git a/pkg/experiment/local/assignment_service_test.go b/pkg/experiment/local/assignment_service_test.go
@@ -18,15 +18,15 @@ func TestToEvent(t *testing.T) {
 			Key: "on",
 			Metadata: map[string]interface{}{
 				"segmentName": "Segment",
-				"version": 13,
+				"flagVersion": float64(13),
 			},
 		},
 		"flag-key-2": {
 			Key:      "control",
 			Metadata: map[string]interface{}{
 				"default": true,
 				"segmentName": "All Other Users",
-				"version": 12,
+				"flagVersion": float64(12),
 			},
 		},
 	}

diff --git a/pkg/experiment/local/client.go b/pkg/experiment/local/client.go
@@ -43,7 +43,7 @@ func Initialize(apiKey string, config *Config) *Client {
 		config = fillConfigDefaults(config)
 		log := logger.New(config.Debug)
 		var as *assignmentService
-		if config.AssignmentConfig != nil && config.AssignmentConfig.Config.IsValid() {
+		if config.AssignmentConfig != nil && config.AssignmentConfig.APIKey != ""  {
 			amplitudeClient := amplitude.NewClient(config.AssignmentConfig.Config)
 			as = &assignmentService{
 				amplitude: &amplitudeClient,