Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve remote evaluation fetch retry logic #20

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Jan 23, 2024

Summary

Improve remote evaluation fetch retry logic

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tyiuhc tyiuhc requested a review from bgiori January 24, 2024 17:02
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to test?

@@ -27,3 +29,12 @@ type Variant struct {
Key string `json:"key,omitempty"`
Metadata map[string]interface{} `json:"metadata,omitempty"`
}

type FetchError struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use internal fetchError

pkg/experiment/types.go Outdated Show resolved Hide resolved
@tyiuhc tyiuhc requested a review from bgiori January 27, 2024 01:57
@tyiuhc tyiuhc merged commit f844a3c into main Jan 29, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
## [1.3.2](v1.3.1...v1.3.2) (2024-01-29)

### Bug Fixes

* Improve remote evaluation fetch retry logic ([#20](#20)) ([f844a3c](f844a3c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants