feat: Add cohort sync #49
Merged
+4,135
−696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhukaihan
force-pushed
the
add-cohort-sync
branch
from
f19d00b
to
f23680c
Compare
tyiuhc
reviewed
Jul 29, 2024
packages/node/src/local/updater.ts
Outdated
| const cohortIds = CohortUtils.extractCohortIds(flagConfigs); | ||
| if (cohortIds && cohortIds.size > 0 && !this.cohortFetcher) { | ||
| throw Error( | ||
| 'cohort found in flag configs but no cohort download configured', |
There was a problem hiding this comment.
Good that this is checked - but what if they want to use only a subset of flags in a deployment, and that subset doesn't require cohorts 🤔 (cc: @bgiori)
tyiuhc
reviewed
Jul 30, 2024
bgiori
reviewed
Aug 5, 2024
packages/node/src/types/config.ts
Outdated
| export const CohortConfigDefaults: Omit<CohortConfig, 'apiKey' | 'secretKey'> = | ||
| { | ||
| cohortServerUrl: 'https://cohort-v2.lab.amplitude.com', | ||
| maxCohortSize: 10_000_000, |
There was a problem hiding this comment.
max cohort size should be 2147483647
tyiuhc
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add cohort targeting and download to SDK.
GH Action changes:
Tests
Unit tests created for all added functions.
Integration test created for user id and group id and group name cohort targeting for US endpoint.
Integration test for EU endpoint contains simple cohort targeting.
Manually tested cohort syncs at flag update interval when cohort was updated.
Checklist