improved syntax, removed MockAssignmentFilter (used for testing)

src/amplitude_experiment/assignment/assignment.py

@@ -17,8 +17,8 @@ def __init__(self, user: User, results: Dict[str, FlagResult]):
     def canonicalize(self) -> str:
         user = self.user.user_id.strip() if self.user.user_id else 'undefined'
         device = self.user.device_id.strip() if self.user.device_id else 'undefined'
-        sb = user + ' ' + device + ' '
+        canonical = user + ' ' + device + ' '
         for key in sorted(self.results):
             value = self.results[key].value.strip() if self.results[key] else 'undefined'
-            sb += key.strip() + ' ' + value + ' '
-        return sb
+            canonical += key.strip() + ' ' + value + ' '
+        return canonical

src/amplitude_experiment/assignment/assignment_config.py

@@ -2,6 +2,7 @@
 
 
 class AssignmentConfig(amplitude.Config):
-    def __init__(self, filter_capacity: int = 65536, **kw):
+    def __init__(self, api_key: str, filter_capacity: int = 65536, **kw):
+        self.api_key = api_key
         self.filter_capacity = filter_capacity
         super(AssignmentConfig, self).__init__(**kw)

src/amplitude_experiment/assignment/assignment_filter.py

@@ -6,8 +6,8 @@
 
 
 class AssignmentFilter:
-    def __init__(self, size: int):
-        self.cache = Cache(size, DAY_MILLIS)
+    def __init__(self, size: int, ttl_millis: int = DAY_MILLIS):
+        self.cache = Cache(size, ttl_millis)
 
     def should_track(self, assignment: Assignment) -> bool:
         now = time.time()

src/amplitude_experiment/flagresult.py

@@ -1,9 +1,9 @@
 class FlagResult:
-    def __init__(self, value: str, is_default_variant: bool, payload: str = None, expkey: str = None,
+    def __init__(self, value: str, is_default_variant: bool, payload: str = None, exp_key: str = None,
                  deployed: bool = None, type: str = None):
         self.value = value
         self.payload = payload
         self.is_default_variant = is_default_variant
-        self.expkey = expkey
+        self.exp_key = exp_key
         self.deployed = deployed
         self.type = type

src/amplitude_experiment/local/client.py

@@ -35,7 +35,6 @@ def __init__(self, api_key: str, config: LocalEvaluationConfig = None):
         self.config = config or LocalEvaluationConfig()
         self.assignment_service = None
         if config and config.assignment_config:
-            print('set assignment service')
             instance = Amplitude(config.assignment_config.api_key, config.assignment_config)
             self.assignment_service = AssignmentService(instance, AssignmentFilter(
                 config.assignment_config.filter_capacity))

tests/local/assignment/assignment_filter_test.py

@@ -2,7 +2,6 @@
 import unittest
 from src.amplitude_experiment import User, FlagResult
 from src.amplitude_experiment.assignment import Assignment, AssignmentFilter
-from tests.local.util.mock_assignment_filter import MockAssignmentFilter
 
 
 class AssignmentFilterTestCase(unittest.TestCase):
@@ -107,7 +106,7 @@ def test_lru_replacement(self):
         self.assertTrue(assignment_filter.should_track(assignment1))
 
     def test_lru_expiration(self):
-        assignment_filter = MockAssignmentFilter(100, 1000)
+        assignment_filter = AssignmentFilter(100, 1000)
         user1 = User(user_id='user1', device_id='device')
         user2 = User(user_id='user2', device_id='device')
         results = {}