Merge pull request #5 from amplitude/AMP-100834-rrweb-fixes

fix(rrweb-snapshot): pass maskInputFn correctly
amplitude · Jun 5, 2024 · 33293b6 · 33293b6
2 parents 97f5d8d + 01c42a7
commit 33293b6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/short-masks-cross.md b/.changeset/short-masks-cross.md
@@ -0,0 +1,5 @@
+---
+'@amplitude/rrweb': patch
+---
+
+fix(rrweb-snapshot): pass maskInputFn correctly
diff --git a/packages/rrdom/test/utils.ts b/packages/rrdom/test/utils.ts
@@ -9,10 +9,12 @@ const _typescript = typescript as unknown as typeof typescript.default;
 export async function compileTSCode(inputFilePath: string) {
   const bundle = await rollup.rollup({
     input: inputFilePath,
+    cache: false,
     plugins: [
       resolve() as unknown as rollup.Plugin,
       _typescript({
         tsconfigOverride: { compilerOptions: { module: 'ESNext' } },
+        clean: true,
       }) as unknown as rollup.Plugin,
     ],
   });

diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts
@@ -378,6 +378,7 @@ function record<T = eventWithTime>(
       inlineStylesheet,
       maskAllInputs: maskInputOptions,
       maskTextFn,
+      maskInputFn,
       slimDOM: slimDOMOptions,
       dataURLOptions,
       recordCanvas,