Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amp 99342 regex error #16

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Amp 99342 regex error #16

merged 8 commits into from
Jun 24, 2024

Commits on Jun 21, 2024

  1. Fix and test for bug rrweb-io#1457 (Uncaught SyntaxError: Regular exp… 

    …ression too large)

 - see test case which is extracted from a real world css file; the selector regex was able to traverse the curly brace as when looking for quotes, it wasn't taking into account that the start quote could be escaped
    @eoghanmurray @jxiwang
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    63d1dd7 View commit details
    Browse the repository at this point in the history

  2. Apply formatting changes

    @eoghanmurray @jxiwang
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d45c841 View commit details
    Browse the repository at this point in the history

  3. Create fair-ducks-clean.md

    @eoghanmurray @jxiwang
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    dc7b283 View commit details
    Browse the repository at this point in the history

  4. Fix @import regex bit which was stopping consumption in the middle of… 

    … a url - need to consume quotes.

Thanks [email protected] for reporting and isolating this case
    @eoghanmurray @jxiwang
    eoghanmurray authored and jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ecd7f3d View commit details
    Browse the repository at this point in the history

  5. AMP-99342: Changeset clean-up

    @jxiwang
    jxiwang committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    25deb6d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'master' into AMP-99342-Regex-Error

    @jxiwang
    jxiwang committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7ea50cb View commit details
    Browse the repository at this point in the history

  2. AMP-99342: Add old changeset

    @jxiwang
    jxiwang committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    aaee874 View commit details
    Browse the repository at this point in the history

  3. Apply formatting changes

    @jxiwang @github-actions
    jxiwang authored and github-actions[bot] committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    54f2367 View commit details
    Browse the repository at this point in the history