Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrweb sync alpha 14 #23

Merged
merged 9 commits into from
Oct 17, 2024
Merged

rrweb sync alpha 14 #23

merged 9 commits into from
Oct 17, 2024

Conversation

jxiwang
Copy link
Collaborator

@jxiwang jxiwang commented Jul 31, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 208ad4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@amplitude/rrweb-snapshot Patch
@amplitude/rrweb Patch
@amplitude/rrdom Patch
@amplitude/rrdom-nodejs Patch
@amplitude/rrweb-player Patch
@amplitude/rrweb-types Patch
@amplitude/rrweb-web-extension Patch
@amplitude/rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

eoghanmurray and others added 7 commits October 16, 2024 15:05
…sion (rrweb-io#1441)

performance: remove a nested function call and an object clone during event emission

 - rename `event` to `eventWithoutTime`, but maintain backwards compatibility
 - `eventWithTime` (with time) could be renamed to `event` in a future version

This is an extension of PR rrweb-io#1339 authored by: mydea <[email protected]>
* Ensure there is separation of timestamps so mutations can be evaluated separately - was failing in the github build process probably due to higher perf

* Remove space from test file

* Create curvy-balloons-brake.md

---------

Co-authored-by: Justin Halsall <[email protected]>
perf(snapshot): avoid costly generation of <a> element on each call to `getHref`, instead cache an anchor element and reuse it's href attributed

---------

Co-authored-by: Eoghan Murray <[email protected]>
…later modified (rrweb-io#1467)

* Fix that blob urls persist on the shared anchor element and can't be later modified

* Create nervous-kiwis-nail.md
Some dev improvements:
* Add .editorconfig config file https://editorconfig.org/
* move the singleQuote spec into .editorconfig and add old .changesets/*.md to .prettierignore so that we don't incorrectly reformat new changeset files to single quote from the double quote which they can be autogenerated with in github
* .gitignore Ignore emacs chaff files
* Add `yarn format:head` a convenience command to run prettier against just those files in the head commit
* Some mention of `yarn format` in the docs
* Fix some test html closing tags; authoring mistakes, rather than deliberately malformed html — picked up by an explicit `yarn prettier --write '**/*.html'`
* Fix that the `.replace()` function only replaces the first occurrence

* This should have been included in rrweb-io#1174

* Create fast-pets-exist.md
This work is to try to provide support where rrweb might be included
in applications with various tools that might override Array.from
so that the 2nd parameter (the map function) will always work for
rrweb.

Co-authored-by: Michael Dellanoce <[email protected]>
@jxiwang jxiwang changed the title Rrweb sync alpha 13 rrweb sync alpha 14 Oct 17, 2024
@jxiwang jxiwang marked this pull request as ready for review October 17, 2024 00:33
@jxiwang jxiwang merged commit a054640 into master Oct 17, 2024
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants