fix(rrweb): external function errors should be tagged #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39adcd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -665,7 +665,9 @@ function initStyleSheetObserver( | |||
| adds: [{ rule, index }], | |||
| }); | |||
| } | |||
| return target.apply(thisArg, argumentsList); | |||
| return externalFunctionWrapper(() => | |||
There was a problem hiding this comment.
I only added this to insertRule and deleteRule since those are the ones that seem relevant for styled components. We can probably expand this further, but limiting the scope of the changes for now (though this should be fairly safe).
There was a problem hiding this comment.
Agreed could be useful for other areas that we would want to differentiate.
jxiwang
approved these changes
Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styled Components depend on the CSS related errors being thrown properly. Currently rrweb uses a Proxy to intercept calls to
window.CSSStyleSheet.prototype.insertRuleand a few other functions. This becomes a problem because rrweb also wraps the error handler around this call, and errors caused by external libraries calling insertRule (for example) are getting caught by rrweb handler.This fix adds an wrapper for these function calls that happen outside of the context of rrweb, and marks the error with an
_external_=trueproperty. This allows us to differentiate the errors on the SDK and decide which errors to re-throw.Relevant SDK change here: amplitude/Amplitude-TypeScript#763