Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to storybook 7.0.0 #54

Conversation

tijmenvangurp
Copy link
Contributor

@tijmenvangurp tijmenvangurp commented Mar 21, 2024

Use the api's from storybook 7.0.0 this makes it compatible with storybook version 8

closes: #53

📦 Published PR as canary version: 2.0.0--canary.54.81fbd2c.0

✨ Test out this PR locally via:

npm install @amplitude/[email protected]
# or 
yarn add @amplitude/[email protected]

@tijmenvangurp
Copy link
Contributor Author

tijmenvangurp commented Mar 21, 2024

@maecapozzi can you verify if this works and merge publish this if possible? Its a minor change not a breaking change.

@smitev
Copy link

smitev commented Mar 25, 2024

I tried this patch locally and it works with Storybook 8.

Is it going to be merged soon?

@jimmynotjim
Copy link
Collaborator

Hi @tijmenvangurp, please see my fixes for your changes and test them to ensure they work with SB v8. tijmenvangurp#1

@jimmynotjim jimmynotjim added the major Increment the major version when merged label Mar 26, 2024
fixes yarn 1 and typescript errors
@tijmenvangurp
Copy link
Contributor Author

Hi @tijmenvangurp, please see my fixes for your changes and test them to ensure they work with SB v8. tijmenvangurp#1

Thanks for looking into this I merged your fixes hope it's good to go like this let me know if there is anything else.

@jimmynotjim
Copy link
Collaborator

@tijmenvangurp great! Unfortunately when I went to check on these changes being published as a canary and I found there's a bug in shipit that's blocking our releases. I'm working on upgrading to the latest version right now. In the mean time, you could point your package.json to your own fork of the repo and branch if you need to unblock yourself.

@jimmynotjim
Copy link
Collaborator

@tijmenvangurp I've fixed our release process. Can you fix the conflict, rebuild the yarn.lock file, and push those back to your branch?

@tijmenvangurp
Copy link
Contributor Author

@tijmenvangurp I've fixed our release process. Can you fix the conflict, rebuild the yarn.lock file, and push those back to your branch?

@jimmynotjim I resolved the conflict on the package.json file there where no changes on the yarn.lock after running yarn.

@jimmynotjim
Copy link
Collaborator

The v2.0.0 Canary is published to NPM with your changes. I'm testing it locally in our own SB setup and will merge and publish assuming I don't find any issues.

@maecapozzi
Copy link
Collaborator

@tijmenvangurp, what version of yarn and what version of react are you on?

I did notice a bug in this PR, where the peer dependencies need to be adjusted if a team is on React 18. Would you mind upgrading to 2.0.0--canary.57.fa4a227.0 to ensure that it's working for you with these changes?

@tijmenvangurp
Copy link
Contributor Author

@tijmenvangurp, what version of yarn and what version of react are you on?

I did notice a bug in this PR, where the peer dependencies need to be adjusted if a team is on React 18. Would you mind upgrading to 2.0.0--canary.57.fa4a227.0 to ensure that it's working for you with these changes?

Its all working for us please go ahead with these changes

@maecapozzi maecapozzi closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook 8 compatibility
4 participants