-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Temporarily) disable slow coverage jobs on Travis #2496
Conversation
The Travis config seems to be correct, but it just doesn't seem to work as expected 😕 I guess for now we could just disable coverage for pull requests like this: --- .travis.yml
+++ .travis.yml
@@ -110,7 +110,7 @@ jobs:
env: WP_VERSION=trunk DEV_LIB_ONLY=phpunit INSTALL_PWA_PLUGIN=1 ALLOW_FAILURES=1
- name: PHP and JavaScript unit tests (7.3, WordPress trunk, with code coverage)
- if: branch = develop
+ if: branch = develop AND type = push
php: "7.3"
env: WP_VERSION=latest DEV_LIB_ONLY=phpunit INSTALL_PWA_PLUGIN=1 RUN_PHPUNIT_COVERAGE=1 ALLOW_FAILURES=1
before_script: |
I like that idea for the short term. |
FYI: Codecov badge support for wp-dev-lib proposed in xwp/wp-dev-lib#299 Update: #2516 |
No coverage reports for PRs now anymore: https://travis-ci.org/ampproject/amp-wp/builds/542669426. Not ideal, but as long as that is only temporary I can live with it. |
No description provided.