Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Temporarily) disable slow coverage jobs on Travis #2496

Merged
merged 6 commits into from
Jun 7, 2019

Conversation

swissspidy
Copy link
Collaborator

No description provided.

@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 3, 2019
@westonruter
Copy link
Member

The coverage job still shows taking 30 minutes:

image

@swissspidy
Copy link
Collaborator Author

The Travis config seems to be correct, but it just doesn't seem to work as expected 😕

I guess for now we could just disable coverage for pull requests like this:

--- .travis.yml
+++ .travis.yml
@@ -110,7 +110,7 @@ jobs:
       env: WP_VERSION=trunk  DEV_LIB_ONLY=phpunit                               INSTALL_PWA_PLUGIN=1                        ALLOW_FAILURES=1
 
     - name: PHP and JavaScript unit tests (7.3, WordPress trunk, with code coverage)
-      if: branch = develop
+      if: branch = develop AND type = push
       php: "7.3"
       env: WP_VERSION=latest DEV_LIB_ONLY=phpunit                               INSTALL_PWA_PLUGIN=1 RUN_PHPUNIT_COVERAGE=1 ALLOW_FAILURES=1
       before_script:

@westonruter
Copy link
Member

I guess for now we could just disable coverage for pull requests like this:

I like that idea for the short term.

@westonruter
Copy link
Member

westonruter commented Jun 5, 2019

FYI: Codecov badge support for wp-dev-lib proposed in xwp/wp-dev-lib#299

Update: #2516

@swissspidy swissspidy added the Infrastructure Changes impacting testing infrastructure or build tooling label Jun 6, 2019
@swissspidy
Copy link
Collaborator Author

No coverage reports for PRs now anymore: https://travis-ci.org/ampproject/amp-wp/builds/542669426. Not ideal, but as long as that is only temporary I can live with it.

@swissspidy swissspidy changed the title [WIP] Experiment with Travis CI config (Temporarily) disable slow coverage jobs on Travis Jun 7, 2019
@swissspidy swissspidy requested a review from westonruter June 7, 2019 09:57
@westonruter westonruter merged commit d9315bf into develop Jun 7, 2019
@westonruter westonruter added this to the v1.2 milestone Jun 7, 2019
@westonruter westonruter deleted the try/less-ci-stages branch June 7, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants