Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try deferring output buffer processing until shutdown hook #6234

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

westonruter
Copy link
Member

Summary

This is an alternative approach to #6233 based on @schlessera's idea in #6232 (comment):

Not yet sure whether this is technically possible, but another way to solve this would be to exit the output buffering callback as soon as possible and defer the processing to another method outside of that callback.

What happens if you add another shutdown handler while within the output buffering callback?

See #6232

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

Plugin builds for 40e1601 are ready 🛎️!

@westonruter westonruter changed the title Try defering output buffer processing until shutdown hook Try deferring output buffer processing until shutdown hook May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant