Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percy to handle visual regression testing #6282

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented May 20, 2021

Summary

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon changed the base branch from develop to update/e2e-environment May 20, 2021 03:59
@pierlon pierlon changed the base branch from update/e2e-environment to develop May 24, 2021 21:11
@pierlon pierlon changed the base branch from develop to update/e2e-environment May 24, 2021 21:13
Base automatically changed from update/e2e-environment to develop May 24, 2021 22:16
@@ -47,6 +47,8 @@
"devDependencies": {
"@babel/core": "7.14.3",
"@babel/plugin-proposal-class-properties": "7.13.0",
"@percy/cli": "^1.0.0-beta.50",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta 55 is the latest version and fixes a bunch of bugs, highly recommend updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants