Validator rollup (#38750)

* cl/488761256 github commit msg missing or malformed * cl/489206825 Allow other cdn domain to host amp runtime. * cl/491380213 n/a * cl/491410969 n/a * cl/491961998 n/a * cl/492000476 github commit msg missing or malformed * cl/494063555 n/a * cl/508406092 Fix AMP for Email spec URLs --------- Co-authored-by: Amaltas Bohra <[email protected]>
ampproject · Apr 13, 2023 · 4532230 · 4532230
1 parent aa18782
commit 4532230
Show file tree

Hide file tree

Showing 39 changed files with 482 additions and 17,758 deletions.
diff --git a/extensions/amp-experiment/0.1/test/validator-amp-experiment.out b/extensions/amp-experiment/0.1/test/validator-amp-experiment.out
@@ -34,7 +34,7 @@ FAIL
 amp-experiment/0.1/test/validator-amp-experiment.html:31:0 The tag 'amp-experiment' appears more than once in the document. (see https://amp.dev/documentation/components/amp-experiment/)
 |      <script type="invalidtype"></script>
 >>     ^~~~~~~~~
-amp-experiment/0.1/test/validator-amp-experiment.html:32:4 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-experiment/0.1/test/validator-amp-experiment.html:32:4 The parent tag of tag 'amphtml engine script' is 'amp-experiment', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |  </amp-experiment>
 |  </body>
 |  </html>
diff --git a/extensions/amp-experiment/1.0/test/validator-amp-experiment.out b/extensions/amp-experiment/1.0/test/validator-amp-experiment.out
@@ -54,7 +54,7 @@ FAIL
 amp-experiment/1.0/test/validator-amp-experiment.html:51:0 The tag 'amp-experiment' appears more than once in the document. (see https://amp.dev/documentation/components/amp-experiment/)
 |      <script type="invalidtype"></script>
 >>     ^~~~~~~~~
-amp-experiment/1.0/test/validator-amp-experiment.html:52:4 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-experiment/1.0/test/validator-amp-experiment.html:52:4 The parent tag of tag 'amphtml engine script' is 'amp-experiment', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |  </amp-experiment>
 |
 |  <!-- Too large of JSON -->

diff --git a/extensions/amp-live-list/0.1/test/validator-amp-live-list.out b/extensions/amp-live-list/0.1/test/validator-amp-live-list.out
@@ -82,7 +82,7 @@ amp-live-list/0.1/test/validator-amp-live-list.html:66:2 The mandatory reference
 amp-live-list/0.1/test/validator-amp-live-list.html:67:4 The tag 'foo' is disallowed.
 |      <script items>
 >>     ^~~~~~~~~
-amp-live-list/0.1/test/validator-amp-live-list.html:68:4 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-live-list/0.1/test/validator-amp-live-list.html:68:4 The parent tag of tag 'amphtml engine script' is 'foo', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |        document.writeln('1, 2, 3');
 |      </script>
 |    </amp-live-list>

diff --git a/extensions/amp-mraid/0.1/test/validator-amp-mraid.out b/extensions/amp-mraid/0.1/test/validator-amp-mraid.out
@@ -14,7 +14,7 @@ FAIL
 |    <!-- Invalid: amp-mraid not allowed in AMP; only allowed in AMP ADS -->
 |    <script async host-service="amp-mraid" src="https://cdn.ampproject.org/v0/amp-mraid-0.1.js"></script>
 >>   ^~~~~~~~~
-amp-mraid/0.1/test/validator-amp-mraid.html:14:2 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-mraid/0.1/test/validator-amp-mraid.html:14:2 The attribute 'host-service' may not appear in tag 'amphtml engine script'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |    <script async src="https://cdn.ampproject.org/v0.js"></script>
 |  </head>
 |  <body>

diff --git a/extensions/amp-script/0.1/test/validator-amp-script.out b/extensions/amp-script/0.1/test/validator-amp-script.out
@@ -110,7 +110,7 @@ amp-script/0.1/test/validator-amp-script.html:83:2 The attribute 'data-ampdevmod
 |    <!-- Invalid: Local script without 'target' or 'id' attributes. -->
 |    <script type=text/plain>
 >>   ^~~~~~~~~
-amp-script/0.1/test/validator-amp-script.html:86:2 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-script/0.1/test/validator-amp-script.html:86:2 The parent tag of tag 'amphtml engine script' is 'body', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |      document.body.textContent = "Hello World!";
 |    </script>
 |
@@ -124,14 +124,14 @@ amp-script/0.1/test/validator-amp-script.html:91:2 The attribute 'type' in tag '
 |    <!-- Invalid: Local script with invalid 'target'. -->
 |    <script type=text/plain target=amp-js id=hello>
 >>   ^~~~~~~~~
-amp-script/0.1/test/validator-amp-script.html:96:2 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-script/0.1/test/validator-amp-script.html:96:2 The parent tag of tag 'amphtml engine script' is 'body', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |      document.body.textContent = "Hello World!";
 |    </script>
 |
 |    <!-- Invalid: Local script without 'target' attribute. -->
 |    <script type=text/plain id=hello>
 >>   ^~~~~~~~~
-amp-script/0.1/test/validator-amp-script.html:101:2 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-script/0.1/test/validator-amp-script.html:101:2 The parent tag of tag 'amphtml engine script' is 'body', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |      document.body.textContent = "Hello World!";
 |    </script>
 |

diff --git a/extensions/amp-story/1.0/test/validator-amp-story-amp-experiment-error.out b/extensions/amp-story/1.0/test/validator-amp-story-amp-experiment-error.out
@@ -36,7 +36,7 @@ FAIL
 |          <!-- Invalid: bare script not allowed as a child of amp-story-grid-layer -->
 |          <script type="application/json">
 >>         ^~~~~~~~~
-amp-story/1.0/test/validator-amp-story-amp-experiment-error.html:36:8 Custom JavaScript is not allowed. (see https://amp.dev/documentation/guides-and-tutorials/learn/validation-workflow/validation_errors/#custom-javascript-is-not-allowed)
+amp-story/1.0/test/validator-amp-story-amp-experiment-error.html:36:8 The parent tag of tag 'amphtml engine script' is 'amp-story-grid-layer', but it can only be 'head'. (see https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#required-markup)
 |            {
 |              "background-color-test": {
 |                "variants": {

diff --git a/validator/js/engine/amp4ads-parse-css.js b/validator/js/engine/amp4ads-parse-css.js