Skip to content

Commit

Permalink
πŸ— Temporary workaround for typing issues in cut-nightly.js (#39428)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielrozenberg authored Sep 1, 2023
1 parent 1ae91e0 commit 87288cd
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions build-system/release-workflows/cut-nightly.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,16 @@ async function getCommit(octokit) {

for (const {sha} of commits.data) {
const checkRuns = (
await octokit.paginate(octokit.rest.checks.listForRef, {
...params,
ref: sha,
'per_page': 100,
})
await octokit.paginate(
// TODO(danielrozenberg): seems to be related to https://github.com/octokit/plugin-paginate-rest.js/issues/350
// restore this when the types match again: await octokit.rest.checks.listForRef,
'GET /repos/{owner}/{repo}/commits/{ref}/check-runs',
{
...params,
ref: sha,
'per_page': 100,
}
)
).filter(
({'external_id': id, name}) =>
id !== GITHUB_EXTERNAL_ID && !CHECKS_TO_SKIP.includes(name)
Expand Down

0 comments on commit 87288cd

Please sign in to comment.