🐛Require src attribute in amp-ad-custom #27624
Conversation
|
Hey @ampproject/wg-caching, these files were changed: |
powerivq
force-pushed
the
amp-ad-custom-validator
branch
from
e8a1edc to
7268b3e
Compare
|
to/ @ampproject/wg-caching for final approval @rcebulko the amp-owners-bot |
|
@calebcordry That's very odd; I'm certain it has worked for groups in the past (though there are TONS of GitHub issues out there trying to address this exact issue of team mentions like probot/probot#337). I'm not sure why this changed, but based on behaviorbot/welcome#17, it looks like maybe this permission can be re-enabled at the repository level. @rsimha When you have a few minutes to spare, can you see if there is an Organization members setting at https://github.com/organizations/ampproject/settings/apps/amp-owners-bot/permissions ? I found that URL at the link above. I've checked all app-level settings that I can access through ampprojectbot, and it seems to me like the app should have Org Member read permissions, but maybe something in the installation settings is blocking that
If so, can you set it to read-only please? |
I am no longer admin for the |
|
The URL 404s for us.
…On Tue, Apr 7, 2020 at 2:19 PM Raghu Simha ***@***.***> wrote:
@rsimha <https://github.com/rsimha> When you have a few minutes to spare,
can you see if there is an *Organization members* setting at
github.com/organizations/ampproject/settings/apps/amp-owners-bot/permissions
?
I am no longer admin for the ampproject
<http://github.com/organizations/ampproject> organization (I was at one
point). Looks like @mrjoro <https://github.com/mrjoro> or @cramforce
<https://github.com/cramforce> are the only people with this permission.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27624 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAV4T36I3IY5U2ZBXWL3R3RLOKFTANCNFSM4MDNB6GQ>
.
|
* cl/305561778 Revision bump for #27624 * cl/305733898 CSS validation changes. * cl/306335254 Revision bump for #27709 * cl/306343181 Fix javascript validator symbol export. * cl/306685743 Revision bump for #27768 Co-authored-by: Greg Grothaus <[email protected]>
To close the loop on this, I noticed that owners-bot @mentions are working again as of this evening. |
|
Yip-yip! Fixed in ampproject/amp-github-apps#796 |
#27614
This requirement should be mandatory but is missing from validator spec. We do not expect to see a large audience encounting problems with it since it would never work.