Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce post-connection timeout setting #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduce post-connection timeout setting #531

wants to merge 1 commit into from

Commits on Jul 23, 2019

  1. Introduce post-connection timeout setting 

    Currently, the timeout for the underlying socket is reset to `0` after a successful connection. This can lead to promises hanging indefinitely / callback not being invoked in case the server become unresponsive. On the other hand, just using the connection timeout may be too short, and introduce runtime errors.

As a solution, introduce a second socket option `postConnectTimeout` which is being applied to the socket rather than resetting the timeout to `0`. If the setting is not provided, a high default timeout of 300000 (5 minutes) is being set, which would still prevent indefinitely blocking clients.
    @hardcodet
    hardcodet authored Jul 23, 2019
    Configuration menu
    Copy the full SHA
    1e4636c View commit details
    Browse the repository at this point in the history