Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the test dir setup in tests/common/setup.nu #103

Merged
merged 8 commits into from
Nov 21, 2023
Merged

refactor the test dir setup in tests/common/setup.nu #103

merged 8 commits into from
Nov 21, 2023

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Nov 19, 2023 •
edited
Loading

description

this PR simply makes sure all the tests use the same base location to dump all their files.

this is computed as a random directory in the new get-random-test-dir command.

Note
i had to add a --no-sanitize switch to get-random-test-dir to disable the sanitization for the tests detect-grafting and tests store-cleaning tests, otherwise the tests did not pass on Windows... 🤷 😆

@amtoine amtoine added tests Something related to the tests of the library core Related to the main `nu-git-manager` module refactor Changes that just moves code around without altering features labels Nov 19, 2023
@amtoine amtoine force-pushed the use-single-test-location branch from 85dc7e8 to d6af09d Compare November 20, 2023 18:13
@amtoine amtoine force-pushed the use-single-test-location branch from 61294e8 to 540df07 Compare November 20, 2023 18:26
@amtoine amtoine marked this pull request as ready for review November 20, 2023 18:28
@amtoine amtoine merged commit 25b7c03 into main Nov 21, 2023
4 checks passed
@amtoine amtoine deleted the use-single-test-location branch November 21, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Related to the main `nu-git-manager` module refactor Changes that just moves code around without altering features tests Something related to the tests of the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use a single test location
1 participant
@amtoine