Dynamic notices fix for table detail page (#2210)

Co-authored-by: MarwanBaghdad <[email protected]> Co-authored-by: Kyeonghoon Kim <[email protected]>
amundsen-io · Nov 16, 2023 · eb7f45b · eb7f45b
1 parent b832431
commit eb7f45b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx b/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx
@@ -254,6 +254,7 @@ export class TableDetail extends React.Component<
     const {
       location,
       getTableData,
+      getNoticesDispatch,
       getTableLineageDispatch,
       match: { params },
     } = this.props;
@@ -265,6 +266,10 @@ export class TableDetail extends React.Component<
       this.key = newKey;
       getTableData(this.key, index, source);
 
+      if (getDynamicNoticesEnabledByResource(ResourceType.table)) {
+        getNoticesDispatch(this.key);
+      }
+
       if (isTableListLineageEnabled()) {
         getTableLineageDispatch(this.key, defaultDepth);
       }
@@ -672,7 +677,8 @@ export class TableDetail extends React.Component<
   }
 
   render() {
-    const { isLoading, statusCode, tableData, notices } = this.props;
+    const { isLoading, isLoadingNotices, notices, statusCode, tableData } =
+      this.props;
     const { sortedBy, currentTab, isRightPanelOpen, selectedColumnDetails } =
       this.state;
     let innerContent: React.ReactNode;
@@ -749,7 +755,9 @@ export class TableDetail extends React.Component<
           </header>
           <div className="single-column-layout">
             <aside className="left-panel">
-              <AlertList notices={aggregatedTableNotices} />
+              {!isLoadingNotices && (
+                <AlertList notices={aggregatedTableNotices} />
+              )}
               <EditableSection
                 title={Constants.DESCRIPTION_TITLE}
                 readOnly={!data.is_editable}

diff --git a/frontend/setup.py b/frontend/setup.py
@@ -45,7 +45,7 @@ def build_js() -> None:
 with open(requirements_path) as requirements_file:
     requirements_dev = requirements_file.readlines()
 
-__version__ = '4.2.0'
+__version__ = '4.2.1'
 
 jira = ['jira==3.0.1']
 asana = ['asana==0.10.3']

diff --git a/frontend/tests/unit/api/metadata/test_v0.py b/frontend/tests/unit/api/metadata/test_v0.py
@@ -9,7 +9,7 @@
 from http import HTTPStatus
 
 from amundsen_application import create_app
-from amundsen_application.api.metadata.v0 import TABLE_ENDPOINT, TYPE_METADATA_ENDPOINT, LAST_INDEXED_ENDPOINT,\
+from amundsen_application.api.metadata.v0 import TABLE_ENDPOINT, TYPE_METADATA_ENDPOINT, LAST_INDEXED_ENDPOINT, \
     POPULAR_RESOURCES_ENDPOINT, TAGS_ENDPOINT, USER_ENDPOINT, DASHBOARD_ENDPOINT, FEATURE_ENDPOINT
 from amundsen_application.config import MatchRuleObject