fix -- handle uncategorized owners #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenarmes
reviewed
Oct 3, 2024
frontend/amundsen_application/static/js/components/OwnerEditor/index.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
253
to
256
| // if any owners uncategorized, set section to null to render an uncategorized owners list | ||
| Object.keys(itemProps).forEach((key) => { | ||
| if (!itemProps[key].additionalOwnerInfo?.owner_category) { | ||
| section = null; | ||
| } | ||
| }); |
There was a problem hiding this comment.
is this needed if you do the other check before this function is called? this feels like it might be more complicated than it needs to be
There was a problem hiding this comment.
Yeah it wasn't needed both places, I deleted it from here.
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D
force-pushed
the
btd-owners-ui-null-check-fe
branch
from
f5b4dc3
to
ddd1137
Compare
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
ozandogrultan
as code owners
kristenarmes
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior PR didn't handle the case of having owner categories configured, but also having some owners without any categories.
Motivation and Context
How Has This Been Tested?
Added unit tests for key cases, tested in our staging environment.
CheckList