Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client.php to replace depracated methods for newer PHP version #33

Open
wants to merge 1 commit into
base: Legacy-DE
Choose a base branch
from

Conversation

Be-Klasen
Copy link

using iconv_set_encoding is deprecated in PHP>50600. The proposed change checks the PHP version and uses the new method instead when appropriate.

using iconv_set_encoding is deprecated in PHP>50600. The proposed change checks the PHP version and uses the new method instead when appropriate.
@jobbrown
Copy link

Why not version_compare() for this? http://php.net/manual/en/function.version-compare.php

Example:

if(version_compare(PHP_VERSION, '5.6.0') >= 0) {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants