Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Exceptions #83

wants to merge 3 commits into from

Conversation

asilgalis
Copy link

Description of changes:

If something bad happens all of the time generic \Exception is throw at all times. It is quite hard to handle such problems properly. One way is to parse exception messages but one should not rely on these messages.

By throwing specific exceptions it would help developers to implement solutions that help to recover from some errors. For example with AmazonPay\IpnHandler:

  • incoming SNS messages can be rejected if signature verification fails.
  • incoming SNS message can be re-processed if connectivity with amazon fails due to timeout for signature verification.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant