Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bencode: drop support for go 1.20 #884

Closed
wants to merge 1 commit into from

Conversation

vassilit
Copy link

@vassilit vassilit commented Dec 4, 2023

No description provided.

@anacrolix
Copy link
Owner

I appreciate the tidy up, but I prefer to make it easier to backport if needed, rather than tighten the constraints, at least for something like this that has no runtime or compile time overhead.

@anacrolix anacrolix closed this Dec 5, 2023
@vassilit
Copy link
Author

vassilit commented Dec 5, 2023

I wouldn't have tidied up either it if it wasn't for commit e10ffd1 « Drop support for Go 1.20 ».
I thought you forgot to clean up here as well :)

@anacrolix
Copy link
Owner

Yeah it was more that it's a hassle to guarantee backward compatibility, but I don't want to throw it away.

Your contributions are welcome, thanks for the consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants