Support ICE servers auth #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying credentials for access to servers, in particular TURN servers.
anacrolix
requested changes
Mar 25, 2024
There was a problem hiding this comment.
This is really good, thanks. Let me know if you don't have time to make the changes and I'll finish it. If you do have time, run https://github.com/anacrolix/gorond over the repo, it will fix up your imports.
|
Thank you sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support passing ICE servers of type
[]webrtc.ICEServerto the client config. This effectively enables the use of TURN servers when NAT traversal is needed. TURN servers normally require authentication, and the current implementation doesn't allow for that in the client config.Fixes #903.