Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pieces with availability of 0 #922

Closed
wants to merge 1 commit into from

Conversation

aritra24
Copy link

@aritra24 aritra24 commented Apr 1, 2024

resolves: #916
Pieces with zero availability shouldn't
consume MaxUnverifiedBytes and shouldn't
be prioritised.

Pieces with zero availability shouldn't
consume MaxUnverifiedBytes and shouldn't
be prioritised.
@anacrolix
Copy link
Owner

Thanks for finding this. The solution isn't quite correct. I am mucking around with a more comprehensive solution at https://github.com/anacrolix/torrent/tree/herp.

Specifically I think it's necessary to ensure requests to individual peers aren't starved by pieces that aren't available to from them.

@aritra24
Copy link
Author

aritra24 commented Apr 2, 2024

Ah that's fair, I wasn't too confident on the solution myself. I can close this pr then. Thanks for helping figure it out ✌🏼

@aritra24 aritra24 closed this Apr 2, 2024
@anacrolix
Copy link
Owner

Thank you for persisting and finding the issue! I'll have a fix in master shortly.

@anacrolix
Copy link
Owner

Fixed in 528c5f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants