Basic support for responding to HashRequest #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also Piece.hasPieceLayer seems to be faulty so I tried fixing it
|
Thanks! Nice implementation. The implementation of hasPieceLayer looks correct. You've constrained the checks to v2 fields in the info but that makes sense. Were you seeing performance issues with the old implementation, or just tidying up? |
|
Ok I tested it pretty well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemented serialization of Hashes and HashReject messages, and the logic of responding to HashRequest. Note that some code relevant to
Pieceis changed and should be reviewed.