Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad7616 Split serial vs parallel modes #1007

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Ad7616 Split serial vs parallel modes #1007

merged 6 commits into from
Nov 9, 2023

Conversation

StancaPop
Copy link
Contributor

The axi_ad7616 IP will now contain only the parallel data path of the ADC and the serial infrastructure will be replaced with the SPI Engine framework within the common block design.

@StancaPop StancaPop force-pushed the ad7616_split_si_pi_v2 branch 3 times, most recently from 3c432c1 to 6167f15 Compare September 20, 2022 14:12
@StancaPop
Copy link
Contributor Author

Guideline check fails with the following message:

Files with name errors:
library/axi_ad7616/axi_ad7616_maxis2wrfifo.v

because the file has been deleted, as it is no longer needed for the axi_ad7616 IP.

@alin724
Copy link
Contributor

alin724 commented Sep 22, 2022

ad7616_sdz_zc706_pi:

  • modify adc_db_io ad_iobuf instantiation similarly to the definition in the ad7616_sdz_zed_pi

ad7616_sdc_zed_pi:

  • Update the conversion start signal to the new name, adc_cnvst, in the parallel system_top and constraints files in the project.

alin724
alin724 previously approved these changes Sep 23, 2022
View reviewed changes
ladace
ladace previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@ladace ladace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@StancaPop StancaPop dismissed stale reviews from ladace and alin724 via b17a817 September 26, 2022 11:26
@StancaPop StancaPop force-pushed the ad7616_split_si_pi_v2 branch 2 times, most recently from b17a817 to bb4ba50 Compare September 26, 2022 13:42
@StancaPop
Copy link
Contributor Author

v2: Regenerated Makefile for ad7616_sdz/zc706

sarpadi
sarpadi previously approved these changes Sep 27, 2022
View reviewed changes
ladace
ladace previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@ladace ladace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@StancaPop StancaPop dismissed stale reviews from ladace and sarpadi via 6a3c101 October 11, 2022 14:36
@StancaPop StancaPop force-pushed the ad7616_split_si_pi_v2 branch 2 times, most recently from 9634def to 301c0a8 Compare October 11, 2022 14:42
@StancaPop
Copy link
Contributor Author

v3: Fix interrupts

@StancaPop
Copy link
Contributor Author

v5. Squashed commits. Rebased to master.

acostina
acostina requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@acostina acostina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IRQ output of AXI_AD7616 us not used any more.

In the system_project.tcl, an example of the non default mode should be given.
make SER_PAR_N=0

Also, ZC706 support can be removed in a separate commit part of this pull request.

@StancaPop
Copy link
Contributor Author

The IRQ output of AXI_AD7616 us not used any more.

In the system_project.tcl, an example of the non default mode should be given. make SER_PAR_N=0

Also, ZC706 support can be removed in a separate commit part of this pull request.

Done.

acostina
acostina previously approved these changes Oct 25, 2023
View reviewed changes
sarpadi
sarpadi previously approved these changes Oct 31, 2023
View reviewed changes
@StancaPop StancaPop dismissed stale reviews from sarpadi and acostina via fd2574c October 31, 2023 14:04
@StancaPop
Copy link
Contributor Author

v6. Added axi_clkgen instead of using only the sys_cpu_clk

PopPaul2021
PopPaul2021 previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build the parallel design without any problems. Looks good to me!

StancaPop and others added 6 commits November 6, 2023 13:53
@StancaPop
axi_ad7616: Remove serial dependencies
1b65171
@StancaPop
ad7616_sdz: Use SPI Engine for serial mode
0a3ee63 
This commit makes the following changes:
Add SPI Engine for serial mode
Add SER_PAR_N build parameter, set default 1 for serial
Fix irq consistency in ad7616_bd.tcl
Fix regmap and offload names
Fix system_top.v GPIOs
@StancaPop
ad7616_sdz: Add fmc pinout
16e4c4f
@StancaPop
ad7616_sdz: Remove zc706 support
11444ce
@StancaPop
ad7616_sdz: Add axi_clkgen
ebfd47d
@StancaPop
docs/projects/ad7616_sdz: Update block diagrams
1f27b4d
@StancaPop StancaPop merged commit 0e0e1e4 into main Nov 9, 2023
@StancaPop StancaPop deleted the ad7616_split_si_pi_v2 branch November 9, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina acostina approved these changes

@PopPaul2021 PopPaul2021 PopPaul2021 left review comments

@ladace ladace Awaiting requested review from ladace ladace is a code owner

@alin724 alin724 Awaiting requested review from alin724

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav

@sarpadi sarpadi Awaiting requested review from sarpadi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@StancaPop @alin724 @LIacob106 @sarpadi @acostina @ladace @PopPaul2021