-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logging of make params to the sysid memory #1038
Conversation
45ba5cc
to
2701c8a
Compare
v2: rebase to master and remove empty new lines from end of files |
2701c8a
to
9eba70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the rebase, it looks good to me!
9eba70f
to
bc59fb5
Compare
0618248
to
98043fd
Compare
98043fd
to
9e6a238
Compare
9e6a238
to
c98a881
Compare
v3: Fixed missing \ and removed "sys rom custom string placeholder " from projects that don't have parameters |
c98a881
to
6d42b41
Compare
6d42b41
to
c283e54
Compare
c283e54
to
57cd954
Compare
@bluncan , I created a rebased branch at build_params_to_sysid_rebased to resolve the merge conflicts. |
57cd954
to
36d4d10
Compare
Signed-off-by: Bogdan Luncan <[email protected]>
36d4d10
to
63f5fa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved the merge conflicts, ready to merge, considering the previous approval of changes in the initial review.
Requested changes were applied
Projects that can be configured using make parameters should now log their build parameters inside the sysid memory.
For some projects that have a lot of parameters the sysid memory address space was also increased to 1024.
Example: