Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-xilinx: Update the generic dependency list #1164

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

AndreiGrozav
Copy link
Contributor

The generic project dependency list contains:
system_top*.v
system_bd.tcl
system_project.tcl
system_constr.xdc
This items will not be included in the auto generated makefiles. But used as generic dependency.

This PR adds:
-wildcard check of system_constr*.xdc.
-wildcard check of system_constr*.tcl.

This wildcards are needed for designs that ,for example, contain files like system_top_lvds.v

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

The generic project dependency list contains:
system_top*.v
system_bd.tcl
system_project.tcl
system_constr.xdc
This items will not be included in the auto generated makefiles. But
used as generic dependency.

This commit adds:
-wildcard check of system_constr*.xdc.
-wildcard check of system_constr*.tcl.
@AndreiGrozav AndreiGrozav merged commit 49cf0f7 into master Sep 7, 2023
1 of 2 checks passed
@AndreiGrozav AndreiGrozav deleted the dev_update_amd_generic_make branch September 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants