Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agilex support for AD9081 #1326

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Agilex support for AD9081 #1326

merged 4 commits into from
Oct 7, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented May 14, 2024 •
edited
Loading

PR Description

Adds support for JESD204B on Agilex 7 (DK-SI-AGI027FA) and the reference design project for AD9081.

Tested on hardware with 8 lanes, 8 converters and a lane rate of 15 GHz.

User guide: https://wiki.analog.com/resources/eval/user-guides/ad9081/quickstart/fm87

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan bluncan force-pushed the agilex_fm87_ad9081 branch 4 times, most recently from 6f2cda1 to 4b7b6e9 Compare May 14, 2024 08:07
@bluncan
Copy link
Contributor Author

bluncan commented May 14, 2024

v2: Fixed guideline checker

LBFFilho
LBFFilho reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some very minor nitpicks (mostly headers).

LBFFilho
LBFFilho requested changes May 28, 2024
View reviewed changes
projects/ad9081_fmca_ebz/fm87/system_constr.sdc Show resolved Hide resolved
projects/ad9081_fmca_ebz/fm87/system_project.tcl Show resolved Hide resolved
projects/ad9081_fmca_ebz/fm87/system_qsys.tcl Show resolved Hide resolved
projects/common/fm87/Makefile Outdated Show resolved Hide resolved
projects/common/fm87/jtag.sdc Show resolved Hide resolved
gastmaier
gastmaier previously requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Laez review,
I was able to synthesize on 23.2 but not on 24.1.
On 24.1 it fails with the following error:

2024.05.21.15:21:59 Error: set_interface_property ref_clk_fgt_2 EXPORT_OF systemclk.out_refclk_fgt_2: No interface named systemclk.out_refclk_fgt_2.
2024.05.21.15:21:59 Error: set_interface_property ref_clk_in EXPORT_OF systemclk.refclk_fgt: No interface named systemclk.refclk_fgt.

The wiki page does not recommend a quartus version, better include the tested version number.

LBFFilho
LBFFilho requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more details (guideline-related)

library/intel/jesd204c_phy/jesd204c_phy_adaptor_rx.v Outdated Show resolved Hide resolved
library/jesd204/jesd204_soft_pcs_tx/jesd204_soft_pcs_tx.v Outdated Show resolved Hide resolved
library/intel/jesd204c_phy/jesd204c_phy_adaptor_rx.v Outdated Show resolved Hide resolved
library/intel/jesd204c_phy/jesd204c_phy_adaptor_tx.v Outdated Show resolved Hide resolved
library/intel/jesd204c_phy/jesd204c_phy_adaptor_tx.v Outdated Show resolved Hide resolved
library/intel/jesd204c_phy/rx_gearbox_64b66b.v Outdated Show resolved Hide resolved
library/jesd204/jesd204_soft_pcs_rx/jesd204_soft_pcs_rx.v Outdated Show resolved Hide resolved
library/jesd204/jesd204_soft_pcs_rx/jesd204_soft_pcs_rx.v Outdated Show resolved Hide resolved
library/jesd204/jesd204_soft_pcs_tx/jesd204_soft_pcs_tx.v Outdated Show resolved Hide resolved
IuliaCMoldovan
IuliaCMoldovan requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header updates and cosmetic changes. I had to specify for each file, because the script doesn't check the Tcl files and a few others, as they are in the exception list

docs/projects/ad9081_fmca_ebz/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9081_fmca_ebz/index.rst Show resolved Hide resolved
library/intel/adi_jesd204/adi_jesd204_hw.tcl Show resolved Hide resolved
library/intel/adi_jesd204/adi_jesd204_hw.tcl Outdated Show resolved Hide resolved
library/intel/axi_adxcvr/axi_adxcvr.v Outdated Show resolved Hide resolved
projects/common/fm87/system_top.v Outdated Show resolved Hide resolved
projects/scripts/adi_project_intel.tcl Outdated Show resolved Hide resolved
projects/common/fm87/fm87_system_qsys.tcl Outdated Show resolved Hide resolved
projects/common/fm87/fm87_system_qsys.tcl Outdated Show resolved Hide resolved
docs/projects/ad9081_fmca_ebz/index.rst Outdated Show resolved Hide resolved
@bluncan
Copy link
Contributor Author

bluncan commented Oct 1, 2024 •
edited by IuliaCMoldovan
Loading

v3: Added missing headers, updated years and removed extra newlines.

Compiles fine with quartus 24.1:

Building ad9081_fmca_ebz_fm87 [/.../hdl/projects/ad9081_fmca_ebz/fm87/ad9081_fmca_ebz_fm87_quartus.log] ... OK

IuliaCMoldovan
IuliaCMoldovan previously approved these changes Oct 2, 2024
View reviewed changes
@IuliaCMoldovan
Copy link
Contributor

Would it be useful to add a warning in the Building the HDL project, saying that the FM87 is supported only from Quartus 24.x? To leave no room for discussions (EZ)

FilipG24
FilipG24 previously approved these changes Oct 2, 2024
View reviewed changes
@bluncan bluncan dismissed stale reviews from FilipG24 and IuliaCMoldovan via 4681e35 October 2, 2024 08:48
@bluncan
Copy link
Contributor Author

bluncan commented Oct 2, 2024

v4: Added warning information about the Quartus 24.1 requirement inside the docs.

@bluncan bluncan requested a review from FilipG24 October 2, 2024 08:49
FilipG24
FilipG24 previously approved these changes Oct 2, 2024
View reviewed changes
IuliaCMoldovan
IuliaCMoldovan previously approved these changes Oct 2, 2024
View reviewed changes
LBFFilho
LBFFilho previously approved these changes Oct 2, 2024
View reviewed changes
@bluncan
ad9081: fm87: Initial commit
018a241 
ad9081: a10soc: Update to support FM87 changes

ad9081: s10soc: Update to support FM87 changes

Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan
docs: ad9081: Added FM87 information
f2dd925 
Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan
Copy link
Contributor Author

bluncan commented Oct 7, 2024

v5: Fixed failing project for a10soc and s10soc due to missing system_project variables

@bluncan bluncan dismissed gastmaier’s stale review October 7, 2024 10:44

not failing on quartus 24.1, was probably a license issue.

@bluncan bluncan merged commit 01dcd3a into main Oct 7, 2024
0 of 3 checks passed
@bluncan bluncan deleted the agilex_fm87_ad9081 branch October 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipG24 FilipG24 FilipG24 approved these changes

@LBFFilho LBFFilho LBFFilho left review comments

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

Assignees
No one assigned
Labels
doc enhancement newcarrier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bluncan @IuliaCMoldovan @gastmaier @LBFFilho @FilipG24