Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projects/ad760x: Add support for new parts. Update documentation #1376

Merged
merged 3 commits into from
Aug 7, 2024
Merged

projects/ad760x: Add support for new parts. Update documentation #1376

merged 3 commits into from
Aug 7, 2024

Conversation

StancaPop
Copy link
Contributor

PR Description

Add support for the following parts: AD7605-4, AD7606-8/6/4, AD7607, AD7608, AD7609.

  • Extend de DEV_CONFIG list to include all the parts and their specific parameters.
  • Add NUM_OF_CH parameter to define the number of channels supported/used. By default it is set to 8. Available options: 8/6/4.

Update documentation to include the HDL changes.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@StancaPop StancaPop mentioned this pull request Jul 10, 2024
Open
gastmaier
gastmaier reviewed Jul 11, 2024
View reviewed changes
docs/library/axi_ad7606x/index.rst Outdated Show resolved Hide resolved
docs/library/axi_ad7606x/index.rst Outdated Show resolved Hide resolved
@sarpadi sarpadi requested a review from gastmaier July 23, 2024 09:34
@bia1708
Copy link
Collaborator

bia1708 commented Jul 24, 2024

RetriggerCI

@IuliaCMoldovan IuliaCMoldovan changed the title Update ad760x projects/ad760x: Add support for new parts. Update documentation Jul 30, 2024
@IuliaCMoldovan
Copy link
Contributor

Looks good! Just to squash the commits and make one for doc and one for the project, and all is done.

@sarpadi
Copy link
Contributor

sarpadi commented Aug 1, 2024

Looks good! Just to squash the commits and make one for doc and one for the project, and all is done.

not needed. we do merge and squash so all commits get squashed eventually

@IuliaCMoldovan
Copy link
Contributor

Looks good! Just to squash the commits and make one for doc and one for the project, and all is done.

not needed. we do merge and squash so all commits get squashed eventually

They're different things and shouldn't be put together in one commit

StancaPop and others added 3 commits August 2, 2024 15:28
@StancaPop @sarpadi
docs: Update ad7606x IP & project doc
def8610 
Signed-off-by: sarpadi <[email protected]>
@sarpadi
axi_ad7606x: Clean up parameters; fix clocking
0b75a44 
There is no real need for different clocking options for this core and because
CDC is not implemented in the core, there is no way to use the EXT_CLK
parameter. Fix syntax, fix IP tcl

Signed-off-by: sarpadi <[email protected]>
@sarpadi
ad7606x: Update project
bf813c6 
Simplify parameters. EXT_CLK parameter was useless.The AD7606X IP Core
does not implment any CDC to allow for clocking options. SPI Engine
option will stick to 32 bits only to cover all parts. We do not need to
build for different number of channels, software can disable them if
needed.In all, the number of bitstreams is greatly reduced and the build
process should be more straight forward. Fix license headers. Update sysid
script for uniformity

Signed-off-by: sarpadi <[email protected]>
@sarpadi
Copy link
Contributor

sarpadi commented Aug 2, 2024

Looks good! Just to squash the commits and make one for doc and one for the project, and all is done.

not needed. we do merge and squash so all commits get squashed eventually

They're different things and shouldn't be put together in one commit

Done

@sarpadi sarpadi merged commit e247152 into main Aug 7, 2024
1 of 3 checks passed
@sarpadi sarpadi deleted the update_ad760x branch August 7, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@alin724 alin724 Awaiting requested review from alin724 alin724 is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

Assignees
No one assigned
Labels
doc new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StancaPop @bia1708 @IuliaCMoldovan @sarpadi @gastmaier