Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad9081_fmca_ebz: Fix ad9081_fmc.txt #1384

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ad9081_fmca_ebz: Fix ad9081_fmc.txt #1384

merged 1 commit into from
Jul 17, 2024

Conversation

AndrDragomir
Copy link
Contributor

PR Description

ad9081_fmc.txt :

  • Fix spi0 pinout
  • Add missing clkin8

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan bluncan self-requested a review July 16, 2024 12:55
bluncan
bluncan previously approved these changes Jul 16, 2024
View reviewed changes
@AndrDragomir AndrDragomir merged commit b2dbaa3 into main Jul 17, 2024
1 of 3 checks passed
@AndrDragomir AndrDragomir deleted the ad9081_fmc branch July 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina acostina approved these changes

@bluncan bluncan bluncan left review comments

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@FilipG24 FilipG24 Awaiting requested review from FilipG24 FilipG24 is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrDragomir @acostina @bluncan