Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sysid parameters fixes #1431

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Sysid parameters fixes #1431

merged 2 commits into from
Aug 28, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Aug 28, 2024

PR Description

The ad9081 + zcu102 project was logging two parameters that didn't exist in the project and were always empty so I removed them.

The ad9081 + vpk180 project was missing the logging of the parameters so I added that.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan bluncan merged commit d647d57 into main Aug 28, 2024
1 of 3 checks passed
@bluncan bluncan deleted the sysid_parameters_fixes branch August 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants