Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AD408X on ZedBoard #1433

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add support for AD408X on ZedBoard #1433

wants to merge 10 commits into from

Conversation

PopPaul2021
Copy link
Contributor

PR Description

This PR adds the following:

  • the ad_serdes_in module was modified to allow external reset
  • the ad_pack module was modified to allow MSB align
  • the up_adc_common exposes the up_adc_ddr_edgesel, up_adc_num_lanes and up_adc_sdr_ddr_n signals
  • AXI_AD408X IP
  • AXI_AD408X IP documentation
  • AD4080 project on ZedBoard
  • AD4080 project on ZedBoard documentation

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

IuliaCMoldovan
IuliaCMoldovan reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, only about non-functional changes

docs/library/axi_ad408x/index.rst Show resolved Hide resolved
docs/library/axi_ad408x/index.rst Outdated Show resolved Hide resolved
docs/library/axi_ad408x/index.rst Show resolved Hide resolved
docs/library/axi_ad408x/index.rst Outdated Show resolved Hide resolved
docs/library/axi_ad408x/index.rst Outdated Show resolved Hide resolved
projects/ad408x_fmc_evb/common/ad408x_fmc_evb_bd.tcl Show resolved Hide resolved
projects/ad408x_fmc_evb/zed/system_project.tcl Outdated Show resolved Hide resolved
projects/ad408x_fmc_evb/zed/system_top.v Show resolved Hide resolved
projects/ad408x_fmc_evb/zed/system_constr.xdc Show resolved Hide resolved
projects/ad408x_fmc_evb/zed/system_bd.tcl Show resolved Hide resolved
@PopPaul2021
Copy link
Contributor Author

V2: Cosmetics after review.

IuliaCMoldovan
IuliaCMoldovan previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also built the project and it looks good to me

PopPaul2021 and others added 9 commits September 3, 2024 13:46
@PopPaul2021
library/xilinx/common/ad_serdes_in: Add external reset option
4d526a1 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
library/common/ad_pack: Add MSB aligned option
cc5d660 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
library/common/up_adc_common: Expose unsyncronized controls
7a24f93 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
library/axi_ad408x: Added IP interface for Xilinx projects
ddec844 
The custom IP interface for AD408x has several operating capabilities:
  - single/dual lane data stream selection
  - bit-slip capability for synchronization
  - filter support

Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
docs/library: Adding AXI-AD408X documentation
5e53460 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
projects/ad408x_fmc_evb: Initial commit for ZedBoard
64b26ff 
The project instantiates:
  - the axi_ad408x interface IP
  - a DMA for the 20bit conversion data stream
  - the maximum clock for the axi_ad408x is 400MHz

Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
docs/projects: Adding documentation for AD4080 project.
7e41615 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
Changes after review
f691714 
library/xilinx/common: Apply indentation patch on ad_serdes_in
docs/projects/ad408x_fmc_evb: Update UG link position

Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
projects/ad408x_fmc_evb: Fix critical warning
763cfe5 
Signed-off-by: PopPaul2021 <[email protected]>
@PopPaul2021
Copy link
Contributor Author

V3: After fixing the critical warning and rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan left review comments

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc newboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PopPaul2021 @IuliaCMoldovan