Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adrv904x_vck190: Initial design #1436

Merged
merged 1 commit into from
Sep 27, 2024
Merged

adrv904x_vck190: Initial design #1436

merged 1 commit into from
Sep 27, 2024

Conversation

AndrDragomir
Copy link
Contributor

PR Description

Versal support for adrv904x.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan
Copy link
Contributor

bluncan commented Aug 29, 2024

Looks good, but you should probably log the build parameters inside the sysid memory since that PR got merged and most (if not all) of the projects do that already.

@bluncan bluncan self-requested a review August 29, 2024 13:21
bluncan
bluncan previously approved these changes Aug 29, 2024
View reviewed changes
@IuliaCMoldovan
Copy link
Contributor

Could you add this project to the CODEOWNERS file?

IuliaCMoldovan
IuliaCMoldovan reviewed Aug 30, 2024
View reviewed changes
projects/adrv904x/common/adrv904x_bd.tcl Outdated Show resolved Hide resolved
projects/adrv904x/common/versal_transceiver.tcl Outdated Show resolved Hide resolved
projects/adrv904x/vck190/system_bd.tcl Outdated Show resolved Hide resolved
projects/adrv904x/vck190/system_constr.xdc Outdated Show resolved Hide resolved
projects/adrv904x/vck190/system_project.tcl Outdated Show resolved Hide resolved
projects/adrv904x/vck190/system_top.v Outdated Show resolved Hide resolved
@IuliaCMoldovan
Copy link
Contributor

Could you edit the documentation and add VCK190 at Supported carriers and in the table for Default values of the make parameters as well?

@AndrDragomir AndrDragomir force-pushed the adrv904x_vck190 branch 4 times, most recently from c91446e to 1a2ff1c Compare September 4, 2024 11:21
@AndrDragomir AndrDragomir merged commit c0cf6ec into main Sep 27, 2024
1 of 3 checks passed
@AndrDragomir AndrDragomir deleted the adrv904x_vck190 branch September 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@bluncan bluncan bluncan left review comments

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
newcarrier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrDragomir @bluncan @IuliaCMoldovan