Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adrv9026: Add vck190 support #1438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AndrDragomir
Copy link
Contributor

PR Description

Versal support for adrv9026 with JESD204B

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the documentation with the changes?

ad_connect tx_0_p ${rx_phy}/tx_0_p
ad_connect tx_0_n ${rx_phy}/tx_0_n
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline character at the end of the file

@@ -0,0 +1,1180 @@
###############################################################################
## Copyright (C) 2021-2024 Analog Devices, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright (C) 2021-2024 Analog Devices, Inc. All rights reserved.
## Copyright (C) 2024 Analog Devices, Inc. All rights reserved.

S=$ad_project_params(TX_JESD_S)\
LINKS=$ad_project_params(TX_NUM_LINKS)"

sysid_gen_sys_init_file $sys_cstring 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

"$ad_hdl_dir/projects/common/vck190/vck190_system_constr.xdc" ]

adi_project_run adrv9026_vck190

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line

Comment on lines 22 to 24
]
adi_project_files adrv9026_vck190 [list \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
adi_project_files adrv9026_vck190 [list \
]
adi_project_files adrv9026_vck190 [list \

//
// 2. An ADI specific BSD license, which can be found in the top level directory
// of this repository (LICENSE_ADIBSD), and also on-line at:
// https://github.com/analogdevicesinc/hdl/blob/master/LICENSE_ADIBSD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// https://github.com/analogdevicesinc/hdl/blob/master/LICENSE_ADIBSD
// https://github.com/analogdevicesinc/hdl/blob/main/LICENSE_ADIBSD

assign tx_data_p[3:0] = tx_data_p_loc[3:0];
assign tx_data_n[3:0] = tx_data_n_loc[3:0];

endmodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

Signed-off-by: AndrDragomir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants