AD7405: Add parametrized make feature and HDL project documentation. #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopPaul2021
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
LBFFilho and
acostina
as code owners
IuliaCMoldovan
requested changes
Oct 2, 2024
PopPaul2021
force-pushed
the
fix_ad7405
branch
2 times, most recently
from
96327a4
to
f5adba0
Compare
|
V3: Updates after review |
IuliaCMoldovan
requested changes
Nov 1, 2024
|
Made squash for commits. |
sarpadi
reviewed
Nov 1, 2024
| "system_constr_differential.xdc" \ | ||
| "$ad_hdl_dir/projects/common/zed/zed_system_constr.xdc"] | ||
|
|
||
| set LVDS_CMOS_N 0 |
There was a problem hiding this comment.
please use this approach as an example on how to deal with build parameters
https://github.com/analogdevicesinc/hdl/blob/main/projects/ad4630_fmc/zed/system_project.tcl#L51-L55
Signed-off-by: Pop Ioan Daniel <[email protected]>
Signed-off-by: Pop Ioan Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Make can now be performed using the LVDS_CMOS_N parameter, which changes the type of data and clock signals to support the AD7405, AD7403, and ADuM7701. The HDL project documentation has also been added.
PR Type
PR Checklist