-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axi_dmac: Delay input packet until IRQ is acknowledged #1486
Open
IstvanZsSzekely
wants to merge
6
commits into
main
Choose a base branch
from
dmac_packet_delay_irq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owledged Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
- Changed parameter name to better reflect its purpose - Updated scripts, version and documentation Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
IstvanZsSzekely
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
LBFFilho and
podgori
as code owners
October 10, 2024 09:09
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Please move the added logic in a submodule - axi_dmac_transfer.v for instance - so that the top module is left for module instantiations only. |
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
I'd like to suggest some improvements for this implementation:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Using the DMA in Scatter-Gather mode multiple interrupts can overlap if the input data rate if faster than what the processing system (PS) can acknowledge. In this case, if the PS is waiting for an interrupt request after each data packet, then some of the interrupts are lost because of this overlap.
This feature introduces a blocking mechanism, that prevents new data to be sent to the DMA until the interrupt has been acknowledged for the previous packet.
Testbench branch
When
SG_DELAYED_INPUT
is set to 1 in the system_bd.tcl under dma_sg_2, the DMA can parse all of the input data packet by packet. Changing this value to 0 will hang the simulation.PR Type
PR Checklist