drivers:platform:stm32: Update SPI desc frequency with configured frequency #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quency Update SPI descriptor clock frequency value with configured value instead of retaining init params value. Signed-off-by: Naga Himanshu Indraganti <[email protected]>
NagaHimanshu
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
buha
reviewed
Dec 13, 2024
| @@ -58,31 +58,41 @@ static int stm32_spi_config(struct no_os_spi_desc *desc) | |||
| switch (div) { | |||
| case 0 ... 2: | |||
| prescaler = SPI_BAUDRATEPRESCALER_2; | |||
| desc->max_speed_hz = sdesc->input_clock / 2; | |||
There was a problem hiding this comment.
hmmm, to be honest i think here it'd be better to keep both, max_speed_hz is the requested maximum speed and there could be an actual_speed_hz with the computed one
i don't think the proposed change is good as it is, either we drop it or we implement both if you really want this info in the desc but this would imply that we populate actual_speed_hz on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SPI descriptor clock frequency value with configured value instead of retaining init params value.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist