Open Alliance SPI support #2438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiprianRegus
requested review from
buha,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
CiprianRegus
force-pushed
the
staging/oa_spi
branch
3 times, most recently
from
095c651 to
fa90171
Compare
The Open Alliance serial interface (OA TC6) is a protocol over an SPI bus, used for full duplex Ethernet frame transfer between a host processor and a 10BASE-T1L or 10BASE-T1S MAC. Implement a generic framework, which can be used to control any MAC which supports the OA SPI protocol. Protocol spec: https://opensig.org/wp-content/uploads/2023/12/OPEN_Alliance_10BASET1x_MAC-PHY_Serial_Interface_V1.1.pdf Signed-off-by: Ciprian Regus <[email protected]>
Add support for the Open Alliance SPI protocol, which can be used as an alternative to the current generic SPI. Signed-off-by: Ciprian Regus <[email protected]>
Add the option to use the Open Alliance SPI protocol for the ADIN1110. In order to enable it, the project has to be compiled with the CONFIG_SWIOT1L_OA_TC6_SPI=y make flag. Signed-off-by: Ciprian Regus <[email protected]>
The OA TC6 SPI files are required to compile the ADIN1110 driver. Add them to the projects which use the MAC-PHY. Signed-off-by: Ciprian Regus <[email protected]>
CiprianRegus
force-pushed
the
staging/oa_spi
branch
from
fa90171 to
d93a622
Compare
buha
approved these changes
Feb 20, 2025
| #define OA_HEADER_LEN 4 | ||
| #define OA_FOOTER_LEN 4 | ||
|
|
||
| #define OA_MMS_REG(m, r) (((m) << 16) | ((r) & NO_OS_GENMASK(15, 0))) |
There was a problem hiding this comment.
tbh i like & 0xffff better because it's shorter :D no need to change, just saying
buha
reviewed
Feb 20, 2025
| @@ -38,6 +38,9 @@ | |||
| #include "no_os_spi.h" | |||
| #include "no_os_gpio.h" | |||
| #include "no_os_util.h" | |||
| #include "no_os_irq.h" | |||
|
|
|||
| #include "oa_tc6.h" | |||
There was a problem hiding this comment.
you'll have to adjust more src.mk files in all affected projects
drivers/net/adin1110/adin1110.h:43:10: fatal error: oa_tc6.h: No such file or directory
buha
reviewed
Feb 20, 2025
| @@ -38,6 +38,9 @@ | |||
| #include "no_os_spi.h" | |||
| #include "no_os_gpio.h" | |||
| #include "no_os_util.h" | |||
| #include "no_os_irq.h" | |||
There was a problem hiding this comment.
this might also have an impact, i didn't check the CI, depending on whether existing projects include .h files one by one or using NO_OS_INC_DIRS
There was a problem hiding this comment.
This is a left over from a previous implementation and is not needed anymore. I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist