Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dac: ad9152: AD9152.c Register Definition Updates #2450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JosefKassai
Copy link
Contributor

Updating AD9152.c to match AD9152.h register definitions, and removing undocumented registers 0x2A6, 0x248, and 0x0E7 per ADGAPPS-2224

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • [N/A] I have updated the documentation (wiki pages, ReadMe etc), if applies

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please properly add the commit body and title to match the 50/72 format. also use the "dac: ad9152:" prefix in your commit tile followed by what the patch is doing.

@JosefKassai JosefKassai force-pushed the AD9152_Header_Updates branch from 2984d64 to a6e6a1e Compare February 17, 2025 14:53
@JosefKassai JosefKassai changed the title Updating AD9152.c to match AD9152.h dac: ad9152: AD9152.C Register Definition Updates Feb 17, 2025
@JosefKassai JosefKassai changed the title dac: ad9152: AD9152.C Register Definition Updates dac: ad9152: AD9152.c Register Definition Updates Feb 17, 2025
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Signed-off-by:" is still missing from your commit. Please have a look at our http://analogdevicesinc.github.io/no-OS/contributing.html#submission-checklist

Fixing AD9152.c register definitions/removing undefined registers. Signed-off-by: JosefKassai
@JosefKassai JosefKassai force-pushed the AD9152_Header_Updates branch from a6e6a1e to 794d260 Compare February 18, 2025 16:34
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the signing is still messed up, have a look at other commits as an example (b09c634)

Or even better use git commit -s

@JosefKassai
Copy link
Contributor Author

@amiclaus, can you clarify how the signature is "messed up"? I see that you also included your email in the "signed-off-by" line, but I don't see this explained in the submission checklist you linked. Also, I believe I did sign it with GPG per the instructions I was given the last time I pulled from this branch:

image

@kister-jimenez
Copy link
Collaborator

@amiclaus, can you clarify how the signature is "messed up"? I see that you also included your email in the "signed-off-by" line, but I don't see this explained in the submission checklist you linked. Also, I believe I did sign it with GPG per the instructions I was given the last time I pulled from this branch:

image

Hi @JosefKassai,

You can amend your commit and add the correct sign-off using for example this:

git commit --amend --signoff

This will user your user.name and user.email configured in your git config. You can then force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants