-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dac: ad9152: AD9152.c Register Definition Updates #2450
base: main
Are you sure you want to change the base?
dac: ad9152: AD9152.c Register Definition Updates #2450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please properly add the commit body and title to match the 50/72 format. also use the "dac: ad9152:" prefix in your commit tile followed by what the patch is doing.
2984d64
to
a6e6a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Signed-off-by:" is still missing from your commit. Please have a look at our http://analogdevicesinc.github.io/no-OS/contributing.html#submission-checklist
Fixing AD9152.c register definitions/removing undefined registers. Signed-off-by: JosefKassai
a6e6a1e
to
794d260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the signing is still messed up, have a look at other commits as an example (b09c634)
Or even better use git commit -s
@amiclaus, can you clarify how the signature is "messed up"? I see that you also included your email in the "signed-off-by" line, but I don't see this explained in the submission checklist you linked. Also, I believe I did sign it with GPG per the instructions I was given the last time I pulled from this branch: |
Hi @JosefKassai, You can amend your commit and add the correct sign-off using for example this: git commit --amend --signoff This will user your user.name and user.email configured in your git config. You can then force push. |
Updating AD9152.c to match AD9152.h register definitions, and removing undocumented registers 0x2A6, 0x248, and 0x0E7 per ADGAPPS-2224
PR Type
PR Checklist