Dev/admt4000 #2462
Open
Dev/admt4000 #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADMT4000 is a zero power, multiturn sensor that can count up to 46 turns of an external magnetic field and report the absolute position via SPI.
This adds tinyIIO support for the ADMT4000 device. This exposes output angular measurements in channels.
Add initial project files and IIO example for ADMT4000.
Add README.rst documentation file for project alongside other documentation related files.
amiclaus
reviewed
Feb 20, 2025
Adding driver RST documentation for ADMT4000
Lcompo
requested review from
buha,
CiprianRegus,
dbogdan,
rbolboac and
danmois
as code owners
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Comment on lines
+1
to
+39
| /***************************************************************************//** | ||
| * @file admt4000.c | ||
| * @brief Implementation of ADMT4000 Driver. | ||
| * @author Marc Sosa ([email protected]) | ||
| * @author Jose Ramon San Buenaventura ([email protected]) | ||
| ******************************************************************************** | ||
| * Copyright 2024(c) Analog Devices, Inc. | ||
| * | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * - Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * - Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in | ||
| * the documentation and/or other materials provided with the | ||
| * distribution. | ||
| * - Neither the name of Analog Devices, Inc. nor the names of its | ||
| * contributors may be used to endorse or promote products derived | ||
| * from this software without specific prior written permission. | ||
| * - The use of this software may or may not infringe the patent rights | ||
| * of one or more patent holders. This license does not release you | ||
| * from the requirement that you obtain separate licenses from these | ||
| * patent holders to use this software. | ||
| * - Use of the software either in source or binary form, must be run | ||
| * on or directly connected to an Analog Devices Inc. component. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY ANALOG DEVICES "AS IS" AND ANY EXPRESS OR | ||
| * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, NON-INFRINGEMENT, | ||
| * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. | ||
| * IN NO EVENT SHALL ANALOG DEVICES BE LIABLE FOR ANY DIRECT, INDIRECT, | ||
| * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, INTELLECTUAL PROPERTY RIGHTS, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
| * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| *******************************************************************************/ |
There was a problem hiding this comment.
The No-OS license has changed to BSD 3 clause. Use that instead. Example here: https://github.com/analogdevicesinc/no-OS/blob/main/include/no_os_crc16.h
Comment on lines
+41
to
+43
| /******************************************************************************/ | ||
| /***************************** Include Files **********************************/ | ||
| /******************************************************************************/ |
There was a problem hiding this comment.
We don't use these comments for new contributions.
| #include "no_os_util.h" | ||
| #include "no_os_alloc.h" | ||
| #include "no_os_delay.h" | ||
|
|
There was a problem hiding this comment.
This whole files uses 4 spaces indentation instead of tabs.
Comment on lines
+119
to
+120
| if (ret < 0) | ||
| goto err; |
| goto err; | ||
|
|
||
| /** Set Direction **/ | ||
| ret |= no_os_gpio_direction_output(dev->gpio_coil_rs, |
There was a problem hiding this comment.
You're checking the error code right after the function call, so there is no need to use the | operator.
|
|
||
| /* Angle Factor Conversion */ | ||
| for (i = 0; i < 2; i++) | ||
| angle[i] = (float)raw_angle[i] * admt4000_angle_conv_factors[i]; |
There was a problem hiding this comment.
We avoid the use of floating point numbers in the driver layer. Can we use radians instead of degrees here, and then return the angle as milliradians?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist